Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented pagination to getAllBilling Plans Endpoint #1316

Open
wants to merge 8 commits into
base: dev
Choose a base branch
from

Conversation

chibuezemicahe
Copy link

Description

This pull request implements pagination for the getAllBillingPlans endpoint. It adds page and limit query parameters to the endpoint, allowing clients to retrieve billing plans in smaller chunks, improving performance and scalability.

Related Issue

Type of Change

  • Added Pagination Feature

How Has This Been Tested?

  • Unit tests

Test Evidence

Screenshot 2025-02-28 at 11 36 09 PM

Documentation Screenshots (if applicable)

Checklist

  • My code follows the project's coding style
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published
  • I have included a screenshot showing all tests passing
  • I have included documentation screenshots (if applicable)

Additional Notes

  • Database Configuration Issues: I encountered significant difficulties setting up the local database connection. I tried [list the things you tried, e.g., different connection strings, different users, different migration strategies], but I was unable to get it working correctly.

  • Mock Data Source: To overcome this issue and demonstrate the pagination functionality, I implemented a mock data source in the BillingPlanService. This allows the API to return paginated results without relying on the database.
    Then did a test to confirm feature was working then removed the mock data

  • Assumptions: This implementation assumes that the database connection will be properly configured in a production environment. The pagination logic should function correctly once the database connection is established.
    -I have tried my best in doing the task and have asked questions whenever problems arise.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants